Fix several Cluster memory leaks #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified memory managament in Cluster credentials API. - Moved several variables into local scopes.
- Improved test documentation, including doc about ProxySQL backend connection pinging algorithm. - Fixed math for working with different number of threads. - Fixed estimations for number of backend connections that should be maintained, and test goal. - Fixed test early return. The test original goal was monitoring the number of connections maintained during an interval, ensuring the behavior was consistent during multiple checks. Any early return or shortcut defeats this purpose, this has increased the test duration. - Added more overloads for helper function 'ext_single_row_val'. - Improved logging.
- Fix race condition on 'check_module_checksums_sync'. - Replaced hardcoded value for CHECKSUM_SYNC_TIMEOUT in favor of computation. - Added extra logging to synchronization checks.
- Improved logging on error handling. - Fixed replication issues in the presence of query rules.
- Removed unused dependencies. - Removed commented code.
|
Retest this please. |
|
Retest this please. |
Added doc elaborating on the limitation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some cluster memory leaks, and also takes the opportunity to:
test_cluster_sync-t: Some timing related failures.test_backend_conn_ping-t: No recent failures, but had issues in the past, reworked to avoid future problems.eof_packet_mixed_queries-t: Recent replication related failures.SHUTDOWN SLOW.